feat(component): add autoComplete prop for selects #542
Conversation
There was a problem hiding this comment.
Small comment, but could you actually show how it fixes #540?
| @@ -7,6 +7,7 @@ import { SelectOptionGroup } from '../Select/types'; | |||
|
|
|||
| interface BaseSelect extends Omit<React.HTMLAttributes<HTMLInputElement>, 'children'> { | |||
| action?: SelectAction; | |||
| autoComplete?: string; | |||
There was a problem hiding this comment.
Can you check that this is not on React.HTMLAttributes<HTMLInputElement>?
There was a problem hiding this comment.
It isn't, I would need to use AllHTMLAttributes
There was a problem hiding this comment.
Ah makes sense. We'd probably want to do this for the Form component too then. (it's only on | off for the form element).
There was a problem hiding this comment.
I assume it defaults to on on the form?
There was a problem hiding this comment.
FormHTMLAttributes does have autoComplete
There was a problem hiding this comment.
Hmm, I could swap the type of the Selects for <React.InputHTMLAttributes<HTMLInputElement> which do include autoComplete and a bunch of others
There was a problem hiding this comment.
🤔
Only thing we need to make sure if we do, is that the types we say we allow (for example, valid input attributes like any aria- ones, or the multiple attribute) are actually passed in to the underlying component. We don't want our types to say we have something that our component doesn't actually implement.
There was a problem hiding this comment.
Lets keep as is since I don't want to expose all those to the user.
jorgemoya
force-pushed
the
select-autocomplete
branch
from
8c3e26a to
6447c66
Compare
jorgemoya
force-pushed
the
select-autocomplete
branch
from
6447c66 to
857bcbf
Compare
What
Allow custom values for autoComplete. Defaults to
off.Why
Fixes #540